This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, generic] Support printing of escaped curly braces and vertical bar in assembler output


Jakub, Richard, thank you for your feedback!

> I wonder if it %{ and %} shouldn't be better handled in final.c
> for all #ifdef ASSEMBLER_DIALECT targets, rather than just for one specific.

I moved %{ and %} cases to output_asm_insn in final.c

> Also:
> *(p + 1)
> should be better written as p[1] (more readable).

Fixed.

I also documented new escapes.
Could you please have a look?

--
Maxim Kuznetsov

Attachment: curly_braces_20130429.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]