This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Generate a label for the split cold function while using -freorder-blocks-and-partition


On Tue, Apr 23, 2013 at 9:59 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Apr 23, 2013 at 03:58:06PM -0700, Sriraman Tallam wrote:
>>   This patch generates labels for cold function parts that are split when
>> using the option -freorder-blocks-and-partition.  The cold label name
>> is generated by suffixing ".cold" to the assembler name of the hot
>> function.
>>
>>   This is useful when getting back traces from gdb when the cold function
>> part does get executed.
>>
>>         * final.c (final_scan_insn): Generate cold label name by suffixing
>>         ".cold" to function's assembler name.
>>         * gcc.dg/tree-prof/cold_partition_label.c: New test.
>
> This doesn't honor NO_DOT_IN_LABEL (and NO_DOLLAR_IN_LABEL).
> Also, don't some function start in cold section and then switch into hot
> section?

That's a good question - with the current trunk implementation it can,
but I have a patch that fixes this and many other bugs I found when
trying to use -freorder-blocks-and-partition. I had sent the patch out
for review awhile ago but it still needs review. See:

http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01303.html
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02141.html (most recent
version of patch).

Teresa

>
>         Jakub



--
Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]