This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR 57022: [4.7/4.8/4.9 Regression] Inappropriate warning for use of TRANSFER with arrays


Am 22.04.2013 15:44, schrieb Mikael Morin:
+  if ((source->expr_type == EXPR_ARRAY || source->rank > 0)
Minor: we can probably assume that rank > 0 if expr_type == EXPR_ARRAY,

Side remark and just for completeness, there is also rank == -1 for assumed-rank arrays. However, as TRANSFER is not an inquiry function, it shouldn't reach that code. (Maybe you could quickly check that that's indeed the case.)


Regarding the patch, I wonder whether the test case should also contain a CHARACTER one, motivated by PR 53685 (esp. comment 7).

Please also include that PR in the ChangeLog.

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]