This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] [MIPS] Fix Many warnings in MIPS port (Was: [PATCH] [MIPS] microMIPS gcc support)


On 04/14/2013 01:27 PM, Moore, Catherine wrote:


-----Original Message-----
From: David Daney [mailto:ddaney.cavm@gmail.com]
Sent: Friday, April 12, 2013 7:29 PM
To: Moore, Catherine
Cc: Rozycki, Maciej; gcc-patches@gcc.gnu.org; Richard Sandiford
Subject: Re: [Patch] [MIPS] Fix Many warnings in MIPS port (Was: [PATCH]
[MIPS] microMIPS gcc support)

On 04/12/2013 03:07 PM, Moore, Catherine wrote:
Hi David,
Please try the attached patch.  Is this OK to checkin?

I don't think it is correct...

And you would be right.  I attached the wrong patch.  Try this one instead:

Index: configure
===================================================================
--- configure   (revision 197950)
+++ configure   (working copy)
@@ -17830,7 +17830,7 @@
    lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
    lt_status=$lt_dlunknown
    cat > conftest.$ac_ext <<_LT_EOF
-#line 17831 "configure"
+#line 17833 "configure"
  #include "confdefs.h"

  #if HAVE_DLFCN_H
@@ -17936,7 +17936,7 @@
    lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
    lt_status=$lt_dlunknown
    cat > conftest.$ac_ext <<_LT_EOF
-#line 17937 "configure"
+#line 17939 "configure"
  #include "confdefs.h"

  #if HAVE_DLFCN_H
@@ -25766,7 +25766,7 @@
    gcc_cv_as_micromips_support=no
    if test x$gcc_cv_as != x; then
      $as_echo '.set micromips' > conftest.s
-    if { ac_try='$gcc_cv_as $gcc_cv_as_flags  -o conftest.o conftest.s >&5'
+    if { ac_try='$gcc_cv_as $gcc_cv_as_flags --fatal-warnings -o conftest.o conftest.s >&5'
    { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
    (eval $ac_try) 2>&5
    ac_status=$?
Index: configure.ac
===================================================================
--- configure.ac        (revision 197950)
+++ configure.ac        (working copy)
@@ -4058,7 +4058,7 @@
           [Define if your assembler supports .gnu_attribute.])])

      gcc_GAS_CHECK_FEATURE([.micromips support],
-      gcc_cv_as_micromips_support,,,
+      gcc_cv_as_micromips_support,,[--fatal-warnings],
        [.set micromips],,
        [AC_DEFINE(HAVE_GAS_MICROMIPS, 1,
            [Define if your assembler supports the .set micromips directive])])


Sorry for the confusion.
Catherine


Your e-mail client mangled it as Content-Transfer-Encoding: quoted-printable, so I had to manually apply it. But after doing that, it does seem to have the desired effect.

So I would say:  Please apply it (After getting somebody to approve it).

Thanks,
David Daney


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]