This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] color diagnostics markers


On Thu, Apr 11, 2013 at 3:54 AM, Gabriel Dos Reis
<gdr@integrable-solutions.net> wrote:
> On Wed, Apr 10, 2013 at 1:42 PM, Manuel López-Ibáñez
> <lopezibanez@gmail.com> wrote:
>> On 9 April 2013 15:21, Jakub Jelinek <jakub@redhat.com> wrote:
>>> white).  The default is still -fdiagnostics-color=never, can be changed
>>> later on.
>>
>> Apart from my comments elsewhere
>> (http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00614.html), the patch
>> looks fine to me. But perhaps we should change the default to auto, at
>> least during Stage 1, to find out whether some bug was introduced. If
>> agreed, I could do this in a follow-up patch that also disables colors
>> for the testsuite.
>>
>> Cheers,
>>
>> Manuel.
>
> I am still of the opinion that the default should be discussed differently,
> and I strongly suggest that it defaults to "never".  I do not believe we do
> need to do otherwise now.
>
> As I stated before, our pursuit of enabling everything new thing by default
> may have made C++ diagnostics more terrifying.

;)

Eventually add a configure switch to allow vendors to change the default.

Richard.

> -- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]