This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Add -gdwarf option to make gcc generate DWARF with the default version
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Senthil Kumar Selvaraj <senthil_kumar dot selvaraj at atmel dot com>
- Cc: gcc-patches at gcc dot gnu dot org, jason at redhat dot com
- Date: Thu, 11 Apr 2013 09:08:08 +0200
- Subject: Re: [Patch] Add -gdwarf option to make gcc generate DWARF with the default version
- References: <20130410132502 dot GA28317 at atmel dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Apr 10, 2013 at 06:55:10PM +0530, Senthil Kumar Selvaraj wrote:
> --- gcc/opts.c
> +++ gcc/opts.c
> @@ -1699,6 +1699,18 @@ common_handle_option (struct gcc_options *opts,
> set_debug_level (SDB_DEBUG, false, arg, opts, opts_set, loc);
> break;
>
> + case OPT_gdwarf:
> + if (arg && strlen(arg) != 0)
The formatting is wrong. Space before ( above missing.
> + {
> + error_at (loc, "%<-gdwarf%s%> is ambiguous; "
> + "use %<-gdwarf-%s%> for DWARF version "
> + "or %<-gdwarf -g%s%> for debug level", arg, arg, arg);
> + break;
> + }
> + else
> + {
> + value = opts->x_dwarf_version;
> + }
A single line statement shouldn't be surrounded inside { }.
ALso, if the OPT_gdwarf case is meant to fallthru into OPT_gdwarf_,
there should be /* FALLTHRU */ or similar comment.
> case OPT_gdwarf_:
> if (value < 2 || value > 4)
> error_at (loc, "dwarf version %d is not supported", value);
Jakub