This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH][Backport 4.7][ARM] Fix PR 56720


> -----Original Message-----
> From: Richard Earnshaw
> Sent: 09 April 2013 14:12
> To: Kyrylo Tkachov
> Cc: gcc-patches@gcc.gnu.org; Ramana Radhakrishnan; 'Jakub Jelinek'
> Subject: Re: [PATCH][Backport 4.7][ARM] Fix PR 56720
> 
> On 05/04/13 16:35, Kyrylo Tkachov wrote:
> > Hi all,
> >
> > This patch is a backport of the fix for PR 56720 where we would ICE
> on
> > arm-*-* when trying to
> > expand vcond with a floating point unorderd comparison cases. The
> patch is
> > almost identical
> > to the trunk patch at:
> > http://gcc.gnu.org/ml/gcc-patches/2013-03/msg00652.html
> > except that it adds explicit handling of the LTGT case which does not
> > require explicit
> > handling in 4.8 and onwards.
> >
> > PR 56720 itself has been fixed on trunk and 4.8 but is present in 4.7
> and
> > 4.6
> >
> > Ok for 4.7 now or when it reopens?
> >
> 
> Is this a regression?  If so, from what?

I've been able to reproduce it in 4.6 and onwards but have not tried any
earlier releases.

> 
> My feeling is that unless this has fixed a regression, it's
> sufficiently
> complex that it's not really appropriate to back-port it to a stable
> branch.

Fair enough, I don't think there's any urgency to get this fixed on earlier
releases.
We can drop this backport then.

Thanks,
Kyrill

> 
> R.
> 
> > Tested arm-none-eabi on qemu.
> >
> > Thanks,
> > Kyrill
> >
> > gcc/ChangeLog
> > 2013-04-05  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> >
> > 	PR target/56720
> > 	* config/arm/iterators.md (v_cmp_result): New mode attribute.
> > 	* config/arm/neon.md (vcond<mode><mode>): Handle unordered cases.
> >
> >
> > gcc/testsuite/ChangeLog
> > 2013-04-05  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> >
> > 	PR target/56720
> > 	* gcc.target/arm/neon-vcond-gt.c: New test.
> > 	* gcc.target/arm/neon-vcond-ltgt.c: Likewise.
> > 	* gcc.target/arm/neon-vcond-unordered.c: Likewise.=
> >
> >
> > neon-vcond-4.7.patch
> >




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]