This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][Backport 4.7][ARM] Fix PR 56720
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Kyrylo Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, 'Jakub Jelinek' <jakub at redhat dot com>
- Date: Tue, 09 Apr 2013 14:12:23 +0100
- Subject: Re: [PATCH][Backport 4.7][ARM] Fix PR 56720
- References: <01ba01ce3213$32af9be0$980ed3a0$ at tkachov@arm.com>
On 05/04/13 16:35, Kyrylo Tkachov wrote:
Hi all,
This patch is a backport of the fix for PR 56720 where we would ICE on
arm-*-* when trying to
expand vcond with a floating point unorderd comparison cases. The patch is
almost identical
to the trunk patch at:
http://gcc.gnu.org/ml/gcc-patches/2013-03/msg00652.html
except that it adds explicit handling of the LTGT case which does not
require explicit
handling in 4.8 and onwards.
PR 56720 itself has been fixed on trunk and 4.8 but is present in 4.7 and
4.6
Ok for 4.7 now or when it reopens?
Is this a regression? If so, from what?
My feeling is that unless this has fixed a regression, it's sufficiently
complex that it's not really appropriate to back-port it to a stable branch.
R.
Tested arm-none-eabi on qemu.
Thanks,
Kyrill
gcc/ChangeLog
2013-04-05 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
PR target/56720
* config/arm/iterators.md (v_cmp_result): New mode attribute.
* config/arm/neon.md (vcond<mode><mode>): Handle unordered cases.
gcc/testsuite/ChangeLog
2013-04-05 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
PR target/56720
* gcc.target/arm/neon-vcond-gt.c: New test.
* gcc.target/arm/neon-vcond-ltgt.c: Likewise.
* gcc.target/arm/neon-vcond-unordered.c: Likewise.=
neon-vcond-4.7.patch