This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,ARM][1/n] New patterns for subtract with carry


On 04/05/13 16:26, Greta Yorsh wrote:

-----Original Message-----
From: Richard Earnshaw
Sent: 22 February 2013 16:30
To: Greta Yorsh
Cc: GCC Patches; Ramana Radhakrishnan; nickc@redhat.com;
paul@codesourcery.com
Subject: Re: [PATCH,ARM][1/n] New patterns for subtract with carry

On 18/02/13 18:35, Greta Yorsh wrote:
Add patterns to handle various subtract with carry operations.

These patterns match RTL insns emitted by splitters
for DImode operations such as subdi, negdi, and cmpdi.

gcc/

2013-02-14  Greta Yorsh  <Greta.Yorsh@arm.com>

          * config/arm/arm.md (subsi3_carryin, subsi3_carryin_const):
New
patterns.
          (subsi3_carryin_compare,subsi3_carryin_compare_const):
Likewise.
          (subsi3_carryin_shift,rsbsi3_carryin_shift): Likewise.



Not ok.  RSC does not exist in Thumb state.

R.

I'm attaching an updated patch. I changed the condition of rsbsi3_carryin_shift pattern and added "arch" attribute to subsi3_carryin as appropriate.

I have also tested the patch again on the recent trunk along with all other patching in this series, which have already been approved. No regressions.

Ok for trunk?


Ok

ramana



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]