This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Use NOTE_P, CALL_P, etc. instead of GET_CODE in a bunch of files

From: Jeff Law <law at redhat dot com>
To: Steven Bosscher <stevenb dot gcc at gmail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 22 Mar 2013 19:57:21 -0600
Subject: Re: [patch] Use NOTE_P, CALL_P, etc. instead of GET_CODE in a bunch of files
References: <CABu31nPbL0CuoAuhze=Eayqpm23j+Uk+r67EAh_yN0DjdjF5OQ at mail dot gmail dot com> <CABu31nP2TG-VQ5pGh7x1nzNyT=+5Fn9xG2eqcE=ww7DQvARrsQ at mail dot gmail dot com>

On 03/22/2013 06:44 PM, Steven Bosscher wrote:

On Fri, Mar 22, 2013 at 8:09 PM, Steven Bosscher wrote:

Hello,

This is an almost completely mechanical replacement of GET_CODE(thing)
== ... with the equivalent predicate macro from rtl.h. This particular
set of files fell victim to my plans for GCC 4.9 to make
JUMP_TABLE_DATA_P a separate rtx instead of a JUMP_INSN. The script I
used is in the patch. I checked and cleaned up the changes by hand and
modified a few places by hand.

Bootstrapped&tested on powerpc64-unknown-linux-gnu and on
ia64-unknown-linux-gnu. Also did a quick cross to a few of the
affected ports (sparc, bfin).
OK for trunk?

Can I please have pre-approval for similar changes to other files,
subject to posting and waiting at least 2 days for
comments/objections?


FWIW, the only other instance where the silly script triggers (apart
from a few wrong INSN_LIST changes) is in mmix.c:

I'll pre-approve the mechanical replacements.

jeff

References:
- [patch] Use NOTE_P, CALL_P, etc. instead of GET_CODE in a bunch of files
  - From: Steven Bosscher
- Re: [patch] Use NOTE_P, CALL_P, etc. instead of GET_CODE in a bunch of files
  - From: Steven Bosscher

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]