This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch cygwin64]: Add and adjust some initial sources for x64 cygwin


On 22/03/2013 09:00, Kai Tietz wrote:

> 	(CXX_WRAP_SPEC_LIST): Undefine before define.

> @@ -73,6 +82,7 @@
> 
>  /* To implement C++ function replacement we always wrap the cxx
>     malloc-like operators.  See N2800 #17.6.4.6 [replacement.functions] */
> +#undef CXX_WRAP_SPEC_LIST
>  #define CXX_WRAP_SPEC_LIST " \
>    --wrap _Znwj \
>    --wrap _Znaj \

  Also, I don't think this is really necessary.  Isn't it the case that
cygwin.h provides base definitions, and cygwin-w64.h overrides them, and it
would always be an error to include cygwin-w64.h before cygwin.h?  In which
case the macro redefinition error would be a useful warning that somebody was
using the headers wrong.

    cheers,
      DaveK



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]