This is the mail archive of the
mailing list for the GCC project.
Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak
- From: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 22 Mar 2013 23:58:36 +0000
- Subject: Re: [patch libgcc]: Adjust cygming-crtbegin code to use weak
- References: <CAEwic4Y5mMhokud4T-ZtA3GAHeWiQsGXfq=goo-2fj9Qm3GHSA at mail dot gmail dot com>
On 22/03/2013 08:44, Kai Tietz wrote:
> this change is actual used by cygwin and is required for upcoming x64
> cygwin target.
> 2013-03-22 Kai Tietz <firstname.lastname@example.org>
> * config/i386/cygming-crtbegin.c (__register_frame_info): Make weak.
> (__deregister_frame_info): Likewise.
> Tested for i686-pc-cygwin, and x86_64-pc-cygwin. I will apply this
> code tomorrow if there are no objections by other
I don't think the ChangeLog entry is right; it doesn't make the declarations
weak, it supplies definitions.
Also, can you explain the motivation for this change? I don't see how it's
going to work right; from what I remember, we don't have weak definitions in
PE-COFF, just weak references. How does the correct definition get chosen
when we may have two definitions in a final link?