This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ PATCH: use identifier_p instead of naked TREE_CODE == IDENTIFIER_NODE
- From: Miles Bader <miles at gnu dot org>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: Gabriel Dos Reis <gdr at axiomatics dot org>, gcc-patches at gcc dot gnu dot org, jason at redhat dot com
- Date: Fri, 22 Mar 2013 13:57:16 +0900
- Subject: Re: C++ PATCH: use identifier_p instead of naked TREE_CODE == IDENTIFIER_NODE
- References: <87vc8kjdou dot fsf at euclid dot axiomatics dot org> <87ehf86oxh dot fsf at catnip dot gol dot com> <CAAiZkiAz=J4xV3ebu1F1v+qVCzxrMCScYsG8LAQr0Lo0XNfmjA at mail dot gmail dot com>
Gabriel Dos Reis <gdr@integrable-solutions.net> writes:
> In many places, we do thinks like:
> 1. test that we have a identifier.
> 2. immediately follow that with access to parts of the
> tree as identifiers, but check again that we really
> an identifier, etc.
>
> There is nothing silly about that.
Sure, it's a common and useful pattern. I'm just saying it's silly to
call it "..._p" in that case...
-miles
--
éäããããæãããéãæããã