This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] cilkplus array notation for C (clean, independent patchset, take 1)


On Wed, Mar 20, 2013 at 11:30:58PM -0600, Jeff Law wrote:
> On 03/20/2013 10:33 AM, Aldy Hernandez wrote:
> >As I'd mentioned, you have .exp files named compile.exp and execute.exp
> >which seem to be causing ambiguity problems in parallel checks (make
> >check -jN).  For some reason, with this patch, the rest of dg.exp fails
> >to run after Cilkplus' compile/execute.exp runs.  Renaming these to
> >something less generic does the trick.  Do you mind prefixing all the
> >.exp's with "cilkplus_" or something similar?

Renaming is desirable anyway, people who run make check-gcc
execute.exp=something don't expect to run also some subset of cilk+ tests.
The Makefile runs some execute.exp=2* and similar when parallelized, see
check_gcc_parallelize in gcc/Makefile.in.
Anyway, have you tested that without parallelization make check doesn't skip
some tests?  Often when a new *.exp file say sets some globals and never
resets them, this could affect following *.exp files.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]