This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, libfortran] Get rid of "enum try"
- From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 19 Mar 2013 13:16:44 +0200
- Subject: Re: [Patch, libfortran] Get rid of "enum try"
- References: <CAO9iq9EhUSia3bJDmGNTkW250rnhGQgnusYOdFE4FJUZjY8zkg at mail dot gmail dot com> <20130117233217 dot GA30813 at troutmask dot apl dot washington dot edu>
On Fri, Jan 18, 2013 at 1:32 AM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Fri, Jan 18, 2013 at 01:19:37AM +0200, Janne Blomqvist wrote:
>>
>> the attached patch gets rid of the "enum try" in the Fortran runtime
>> library, replacing its usage with the standard C99 _Bool/bool.
>>
>> Regtested on x86_64-unknown-linux-gnu, Ok for trunk?
>>
>> 2013-01-18 Janne Blomqvist <jb@gcc.gnu.org>
>>
>> * libgfortran.h: Include stdbool.h.
>> (enum try): Remove.
>> (notify_std): Change return type to bool.
>> * intrinsics/chmod.c: Don't include stdbool.h.
>> * intrinsics/execute_command_line.c: Likewise.
>> * io/format.c: Likewise.
>> * io/list_read.c (nml_parse_qualifier): Change return type to bool.
>> (nml_read_obj): Likewise.
>> (nml_get_obj_data): Likewise.
>> * io/transfer.c (read_block_form): Fix comment.
>> (write_buf): Change return type to bool.
>> * io/write.c: Don't include stdbool.h.
>> * io/write_float.def (output_float): Change return type to bool.
>> (output_float_FMT_G_ ## x): Change type of result variable.
>> * runtime/error.c (notify_std): Change return type to bool.
>>
>>
>
> The patch looks fine to me. As this doesn't fix a regression
> or documentation, you may want to wait for trunk to re-open
> before applying the patch (or ask RM).
Thanks for the review. Committed to trunk (4.9), now that it's
re-opened, as r196791.
--
Janne Blomqvist