This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix install-plugin on arm and aarch64
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Marcus Shawcroft <marcus dot shawcroft at arm dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 6 Mar 2013 23:04:54 +0000
- Subject: Re: [PATCH] Fix install-plugin on arm and aarch64
- References: <20130306090736.GQ12913@tucnak.redhat.com>
- Reply-to: ramrad01 at arm dot com
On Wed, Mar 6, 2013 at 9:07 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> https://bugzilla.redhat.com/show_bug.cgi?id=910926
> reports that plugins aren't usable on arm, because arm-cores.def isn't
> installed into the plugins directory. arm-cores.def can't be included in
> tm_file list, because we don't want to include it directly, nor in
> HeaderInclude in arm.opt (that breaks the build). rs6000 has similar issue
> with its rs6000-builtin.def, and solves this by adding content to TM_H
> in Makefile fragment.
>
> Thus, the following patch does the same for arm (and apparently aarch64 has
> the same issue). Ok for trunk?
>
> 2013-03-06 Jakub Jelinek <jakub@redhat.com>
>
> * config/aarch64/t-aarch64 (TM_H, OPTIONS_H_EXTRA): Add
> aarch64-cores.def.
> * config/arm/t-arm (TM_H, OPTIONS_H_EXTRA): Add arm-cores.def.
Ok.
Thanks,
Ramana
>
> --- gcc/config/aarch64/t-aarch64.jj 2013-02-24 19:44:07.000000000 +0100
> +++ gcc/config/aarch64/t-aarch64 2013-03-06 09:42:31.568042231 +0100
> @@ -18,6 +18,9 @@
> # along with GCC; see the file COPYING3. If not see
> # <http://www.gnu.org/licenses/>.
>
> +TM_H += $(srcdir)/config/aarch64/aarch64-cores.def
> +OPTIONS_H_EXTRA += $(srcdir)/config/aarch64/aarch64-cores.def
> +
> $(srcdir)/config/aarch64/aarch64-tune.md: $(srcdir)/config/aarch64/gentune.sh \
> $(srcdir)/config/aarch64/aarch64-cores.def
> $(SHELL) $(srcdir)/config/aarch64/gentune.sh \
> --- gcc/config/arm/t-arm.jj 2013-01-11 09:03:13.000000000 +0100
> +++ gcc/config/arm/t-arm 2013-03-06 09:41:09.607528642 +0100
> @@ -18,6 +18,9 @@
> # along with GCC; see the file COPYING3. If not see
> # <http://www.gnu.org/licenses/>.
>
> +TM_H += $(srcdir)/config/arm/arm-cores.def
> +OPTIONS_H_EXTRA += $(srcdir)/config/arm/arm-cores.def
> +
> # All md files - except for arm.md.
> # This list should be kept in alphabetical order and updated whenever an md
> # file is added or removed.
>
> Jakub
> [A