This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix install-plugin on arm and aarch64

On 06/03/13 09:07, Jakub Jelinek wrote:
reports that plugins aren't usable on arm, because arm-cores.def isn't
installed into the plugins directory.  arm-cores.def can't be included in
tm_file list, because we don't want to include it directly, nor in
HeaderInclude in arm.opt (that breaks the build).  rs6000 has similar issue
with its rs6000-builtin.def, and solves this by adding content to TM_H
in Makefile fragment.

Thus, the following patch does the same for arm (and apparently aarch64 has
the same issue).  Ok for trunk?

2013-03-06 Jakub Jelinek <>

	* config/aarch64/t-aarch64 (TM_H, OPTIONS_H_EXTRA): Add
	* config/arm/t-arm (TM_H, OPTIONS_H_EXTRA): Add arm-cores.def.

--- gcc/config/aarch64/t-aarch64.jj	2013-02-24 19:44:07.000000000 +0100
+++ gcc/config/aarch64/t-aarch64	2013-03-06 09:42:31.568042231 +0100
@@ -18,6 +18,9 @@
  #  along with GCC; see the file COPYING3.  If not see
  #  <>.

+TM_H += $(srcdir)/config/aarch64/aarch64-cores.def
+OPTIONS_H_EXTRA += $(srcdir)/config/aarch64/aarch64-cores.def
  $(srcdir)/config/aarch64/ $(srcdir)/config/aarch64/ \
  	$(SHELL) $(srcdir)/config/aarch64/ \
--- gcc/config/arm/t-arm.jj	2013-01-11 09:03:13.000000000 +0100
+++ gcc/config/arm/t-arm	2013-03-06 09:41:09.607528642 +0100
@@ -18,6 +18,9 @@
  # along with GCC; see the file COPYING3.  If not see
  # <>.

+TM_H += $(srcdir)/config/arm/arm-cores.def
+OPTIONS_H_EXTRA += $(srcdir)/config/arm/arm-cores.def
  # All md files - except for
  # This list should be kept in alphabetical order and updated whenever an md
  # file is added or removed.


AArch64 patch is OK.

ARM looks fine but I can't OK that one.

Cheers /Marcus

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]