This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR 56043, Fix segfault in 4.7/4.8 powerpc tests
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Michael Meissner <meissner at linux dot vnet dot ibm dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 7 Feb 2013 20:46:48 -0500
- Subject: Re: [PATCH] PR 56043, Fix segfault in 4.7/4.8 powerpc tests
- References: <20130207223408.GA19552@ibm-tiger.the-meissners.org>
On Thu, Feb 7, 2013 at 5:34 PM, Michael Meissner
<meissner@linux.vnet.ibm.com> wrote:
> The following patch fixes a segmentation fault for the powerpc-none-eabi
> toolchain on the vsx-mass-1.c test. Some of the builtin functions are not
> defined in that environment, and the compiler did not check whether a pointer
> was NULL before using it. I also fixed the test so that it would only run
> under powerpc*-*-linux*, since the text would fail on systems like eabi because
> some of the builtin functions would not call their vector counterparts in the
> MASS library.
>
> I've built both 4.8 and 4.7 with this patch, and I didn't notice any
> regressions. Is it ok to install in both the 4.7 tree and trunk?
>
> [gcc]
> 2013-02-07 Michael Meissner <meissner@linux.vnet.ibm.com>
>
> PR target/56043
> * config/rs6000/rs6000.c (rs6000_builtin_vectorized_libmass):
> If there is no implicit builtin declaration, just return NULL.
>
> [gcc/testsuite]
> 2013-02-07 Michael Meissner <meissner@linux.vnet.ibm.com>
>
> PR target/56043
> * gcc.target/powerpc/vsx-mass-1.c: Only run this test on
> powerpc*-*-linux*.
Okay.
Thanks, David