RE: [PATCH][ARM][3/3] Add vectorization support for rounding functions

["Kyrylo Tkachov" <kyrylo dot tkachov at arm dot com>]

Hi all,
This testsuite patch has been okayed at
http://gcc.gnu.org/ml/gcc-patches/2012-12/msg01141.html
but I have not applied it and I'd like to add a couple of things to it.

Currently, add_options_for_arm_v8_neon would explicitly set
-mfloat-abi=softfp which would break
check_effective_target_arm_v8_neon_hw for configurations with hard float
ABI, thus preventing the execution tests that use this check in gcc.dg/vect
from running.
This patch fixes that.

Ok to put it in with the other two ARM rounding vectorization patches that
have been okayed for stage1?

Thanks,
Kyrill

gcc/testuite/ChangeLog

2013-02-07  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	* lib/target-supports.exp (check_effective_target_arm_v8_neon_hw):
	New procedure.
	(check_effective_target_arm_v8_neon_ok_nocache):
	Likewise.
	(check_effective_target_arm_v8_neon_ok): Change to use
	check_effective_target_arm_v8_neon_ok_nocache.
	(add_options_for_arm_v8_neon): Use et_arm_v8_neon_flags to set ARMv8
	NEON flags.
	(check_effective_target_vect_call_btruncf):
	Enable for arm and ARMv8 NEON.
	(check_effective_target_vect_call_ceilf): Likewise.
	(check_effective_target_vect_call_floorf): Likewise.
	(check_effective_target_vect_call_roundf): Likewise.
	(check_vect_support_and_set_flags): Handle ARMv8 NEON effective
	target.

> -----Original Message-----
> From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-
> owner@gcc.gnu.org] On Behalf Of Kyrylo Tkachov
> Sent: 18 December 2012 13:34
> To: gcc-patches@gcc.gnu.org
> Cc: Ramana Radhakrishnan; Richard Earnshaw
> Subject: [PATCH][ARM][3/3] Add vectorization support for rounding
> functions
> 
> Hi all,
> This patch adds arm and v8 NEON to the effective target checks that are
> used
> in the rounding functions vectorisation tests.
> A new effective target check for NEON hardware is added This check is
> used
> to determine
> whether to do runtime tests or just compilation.
> 
> With these changes the following tests now PASS on arm instead of being
> UNSUPPORTED:
> * gcc.dg/vect/vect-rounding-btrunc.c
> * gcc.dg/vect/vect-rounding-ceilf.c
> * gcc.dg/vect/vect-rounding-floorf.c
> * gcc.dg/vect/vect-rounding-roundf.c
> 
> Tested on arm-none-eabi with model and softfp float ABI.
> 
> Ok for trunk?
> 
> Thanks,
> Kyrill
> 
> gcc/testuite/ChangeLog
> 
> 2012-12-18  Kyrylo Tkachov  <kyrylo.tkachov at arm.com>
> 
> 	* lib/target-supports.exp
> (check_effective_target_arm_v8_neon_hw):
> 	  New procedure.
> 	  (check_effective_target_vect_call_btruncf):
> 	  Add check for arm and ARMv8 NEON.
> 	  (check_effective_target_vect_call_ceilf): Likewise.
> 	  (check_effective_target_vect_call_floorf): Likewise.
> 	  (check_effective_target_vect_call_roundf): Likewise.
> 	  (check_vect_support_and_set_flags): Handle ARMv8 NEON effective
> target.

Attachment: vectorized_vrint_test.txt
Description: Text document