This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

From: Jason Merrill <jason at redhat dot com>
To: Sriraman Tallam <tmsriram at google dot com>
Cc: Jakub Jelinek <jakub at redhat dot com>, Richard Henderson <rth at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 07 Feb 2013 09:29:56 -0500
Subject: Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)
References: <20130118202236.GE7269@tucnak.redhat.com> <50FAC778.9040702@redhat.com> <20130121143248.GM7269@tucnak.redhat.com> <51092641.7080005@redhat.com> <CAAs8HmyVs3i2v=MH+djkqROHEGbZXYE7Dyga9oCVO-v1ekiUYw@mail.gmail.com>

On 02/06/2013 08:39 PM, Sriraman Tallam wrote:

+// Test to check if an error is generated when virtual functions
+// are multiversioned.

This seems like a TODO, rather than something to test for. I don't see any reason why we couldn't support multiversioned virtual functions.

     error_at (DECL_SOURCE_LOCATION (decl),
-	      "Virtual function versioning not supported\n");
+	      "Virtual function multiversioning not supported\n");

And so this should be a sorry rather than an error.

Jason

Follow-Ups:
- Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)
  - From: Sriraman Tallam

References:
- Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)
  - From: Sriraman Tallam

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]