This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 55978: [4.8 Regression] class_optional_2.f90 -Os fails
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Janus Weil <janus at gcc dot gnu dot org>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 6 Feb 2013 17:32:32 +0100
- Subject: Re: [Patch, Fortran] PR 55978: [4.8 Regression] class_optional_2.f90 -Os fails
- References: <CAKwh3qistP417Btc+0y44h5UC7pbN2tmoZuY+DMQ+d97fOGjpg@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Feb 06, 2013 at 04:30:41PM +0100, Janus Weil wrote:
> internal_pack. While this can potentially decrease performance (due to
> the additional function call, which I hope is negligible), it ensures
You mean comparison + conditional jump (predicted unlikely to jump).
> that this check is really done in all possible situations, which makes
> internal_pack somewhat safer.
>
> The patch was regtested on x86_64-unknown-linux-gnu. Ok for trunk?
It looks good to me, but I guess I'll leave the decision to Fortran
reviewers.
Jakub