This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR56008 (and PR47517) [F03] wrong code with lhs-realloc on assignment with derived types having allocatable components
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Guenther <rguenther at suse dot de>, Jakub Jelinek <jakub at redhat dot com>, stefan dot mauerberger at gmail dot com, Dominique Dhumieres <dominiq at lps dot ens dot fr>
- Date: Mon, 4 Feb 2013 23:35:30 +0100
- Subject: Re: [Patch, fortran] PR56008 (and PR47517) [F03] wrong code with lhs-realloc on assignment with derived types having allocatable components
- References: <CAGkQGi+bX8=w354dmtfD5ECm=ZXA5xi3q12sjg-Z9mpxW_=UUA@mail.gmail.com> <5106EB0F.7010601@netcologne.de>
Committed revision 195741.
Thanks for the review.
Paul
On 28 January 2013 22:18, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hi Paul,
>
>
>> This patch is sufficiently straightforward that the ChangeLog entry
>> describes it completely. The fix for both bugs lay in the
>> nullification of the allocatable components of the newly (re)allocated
>> array.
>
>
> I think this fix is OK for trunk, for the reasons you mentioned. I also
> think it is straightforward enough (bordering on the obvious, but only
> after having read it :-) that it does not carry too much risk of a
> regression.
>
> So yes, OK from my side, unless somebody speaks up really quickly.
>
> Thomas
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy