This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix PR sanitizer/55617
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Jack Howarth <howarth at bromo dot med dot uc dot edu>, gcc-patches at gcc dot gnu dot org, dodji at redhat dot com, kcc at google dot com, dvyukov at google dot com, glider at google dot com, mikestump at comcast dot net, iain at codesourcery dot com
- Date: Mon, 4 Feb 2013 10:38:29 +0100
- Subject: Re: [PATCH] fix PR sanitizer/55617
- References: <20130203045748.GA23486@bromo.med.uc.edu> <CAFiYyc3F67ZsygtsH2G2E2=YA27E3bskco9+QJF+6R2kG=cphw@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Feb 04, 2013 at 10:22:48AM +0100, Richard Biener wrote:
> > Okay for gcc trunk?
>
> But that does not work across translation units, no? ISTR collect2 has support
> to handle constructor priorities all by itself (at link time,
> considering all inputs).
I wonder why the patch turned from initially at least supporting intra-CU
support for ctor priorities into an ugly hack for asan. I guess asan
doesn't care too much about inter-CU ctor priorities, it just needs its
ctors to run before anything in the same CU is called (mainly the
__asan_init call), other CUs either won't be asan instrumented, then it
doesn't matter, or will be, but they will have their own __asan_init call.
> I wonder why darwin cannot use that mechanism to support init priorities?
But sure, if collect2 can be used for full init prio support, the better.
Jakub