This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/6] [AArch64-4.7] Fix warning - aarch64_trampoline_init passes the wrong type to emit_library_call.

From: Richard Earnshaw <rearnsha at arm dot com>
To: James Greenhalgh <james dot greenhalgh at arm dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
Date: Sat, 02 Feb 2013 14:24:51 +0000
Subject: Re: [PATCH 4/6] [AArch64-4.7] Fix warning - aarch64_trampoline_init passes the wrong type to emit_library_call.
References: <1359740555-10179-1-git-send-email-james.greenhalgh@arm.com> <1359740555-10179-5-git-send-email-james.greenhalgh@arm.com>

On 01/02/13 17:42, James Greenhalgh wrote:

Hi,
emit_library_call takes an `enum library_type` as its second argument.
Currently aarch64-4.7-branch passes it an int 0.
This patch fixes this, mirroring trunk, by passing LCT_NORMAL instead.

This patch fixes the warning:
config/aarch64/aarch64.c: In function âaarch64_trampoline_initâ:
config/aarch64/aarch64.c:3893:8: warning: enum conversion when passing argument 2 of âemit_library_callâ is invalid in C++ [-Wc++-compat]
Regression tested on aarch64-none-elf with no regressions.

OK for aarch64-4.7-branch?
Thanks,
James
---
gcc/
2013-02-01 James Greenhalgh <james.greenhalgh@arm.com>
	* config/aarch64/aarch64.c
	(aarch64_trampoline_init): Pass 'LCT_NORMAL' rather than '0'
	to emit_library_call.

OK.

R.

References:
- [Patch 0/6][AArch64-4.7] Fix warnings.
  - From: James Greenhalgh
- [PATCH 4/6] [AArch64-4.7] Fix warning - aarch64_trampoline_init passes the wrong type to emit_library_call.
  - From: James Greenhalgh

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]