This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR55882

From: Eric Botcazou <ebotcazou at adacore dot com>
To: Richard Biener <rguenther at suse dot de>
Cc: gcc-patches at gcc dot gnu dot org
Date: Thu, 10 Jan 2013 13:22:21 +0100
Subject: Re: [PATCH] Fix PR55882
References: <alpine.LNX.2.00.1301091254470.6889@zhemvz.fhfr.qr> <alpine.LNX.2.00.1301101005470.6889@zhemvz.fhfr.qr> <alpine.LNX.2.00.1301101033550.6889@zhemvz.fhfr.qr>

> Going over this what's strange as well is that we adjust MEM_SIZE
> with bitpos, too.  At least when the MEM has non-BLKmode this
> means that MEMs mode and MEM_SIZE is inconsistent?  Or how do
> a MEMs mode and MEM_SIZE relate?

Yes, the MEM attributes are incomplete/inconsistent between the call to 
set_mem_attributes_minus_bitpos and the subsequent adjustment by bitpos.
That's why only the final result should matter and need be correct.

Let me try to forge my own opinion on the PR before answering further.

-- 
Eric Botcazou

Follow-Ups:
- Re: [PATCH] Fix PR55882
  - From: Michael Matz

References:
- [PATCH] Fix PR55882
  - From: Richard Biener
- Re: [PATCH] Fix PR55882
  - From: Richard Biener
- Re: [PATCH] Fix PR55882
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]