This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Use libstdc++-raw-cxx.m4 in libjava
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Paolo Bonzini <bonzini at gnu dot org>, DJ Delorie <dj at redhat dot com>, neroden at gcc dot gnu dot org, Alexandre Oliva <aoliva at redhat dot com>, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 03 Jan 2013 19:09:31 +0100
- Subject: Re: Use libstdc++-raw-cxx.m4 in libjava
- References: <CAMe9rOozsRTt6UAoucB6hbw4eKbhN5U5YZBSE0etB5Lj_emZfA@mail.gmail.com> <20130102111116.GP2315@tucnak.redhat.com> <m2txqz3jvo.fsf@igel.home> <CAMe9rOrvnf7oobhV8ukeS+7mn3Gn=8DqQFdfbkM+WLYYxx-Z+A@mail.gmail.com>
"H.J. Lu" <hjl.tools@gmail.com> writes:
> diff --git a/libjava/Makefile.am b/libjava/Makefile.am
> index c6c84e4..dd08a4f 100644
> --- a/libjava/Makefile.am
> +++ b/libjava/Makefile.am
> @@ -594,7 +594,7 @@ lib_gnu_awt_xlib_la_CPPFLAGS = \
> $(AM_CPPFLAGS) \
> $(LIBSTDCXX_RAW_CXX_CXXFLAGS)
> ## The mysterious backslash in the grep pattern is consumed by make.
> -lib_gnu_awt_xlib_la_LDFLAGS = $(LIBSTDCXX_RAW_CXX_LDLAGS) \
> +lib_gnu_awt_xlib_la_LDFLAGS = $(LIBSTDCXX_RAW_CXX_LIBADD) \
> @X_PRE_LIBS@ @X_LIBS@ -lX11 @X_EXTRA_LIBS@ \
> -rpath $(toolexeclibdir) $(LIBJAVA_LDFLAGS_NOUNDEF) \
> -version-info `grep -v '^\#' $(srcdir)/libtool-version`
> $(LIBGCJ_LD_SYMBOLIC)
It is still wrong to use LDFLAGS for libraries to be linked in.
All of $(LIBSTDCXX_RAW_CXX_LIBADD) @X_PRE_LIBS@ @X_LIBS@ -lX11
@X_EXTRA_LIBS@ should be on lib_gnu_awt_xlib_la_LDADD.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."