This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic


Hi,

Thank you very much for your input! Please, take a look at the updated version:
I fixed coding style, moved documentation for TARGET_LIBC_HAS_FUNCTION
to target.def.
Removed TARGET_C99_FUNCTIONS and TARGET_HAS_SINCOS and all their
influence and moved the implementation of linux_libc_has_function to
host-linux.c.
	I changed the defaults: now it is assumed that we have C99 runtime,
but no sincos. I updated all needed gcc/config/*.h. But 'm not sure in
this part,
cause I don't have the opportunity to test it properly...

thank you,
Alexander

2012/12/19 Joseph S. Myers <joseph@codesourcery.com>:
> On Thu, 13 Dec 2012, Alexander Ivchenko wrote:
>
>> Could you please take a look at the attached patch that implements
>> the target libc_has_function hook? I didn't change so far the default presence
>> of c99, but rather tried to preserve the current behaviour of
>> TARGET_C99_FUNCTIONS.
>
> It looks like a plausible starting point, given the changed default,
> coding style fixes (you're missing spaces before '('), documentation text
> moved from tm.texi.in to target.def, removal of TARGET_C99_FUNCTIONS
> documentation, poisoning of TARGET_C99_FUNCTIONS in system.h and moving
> the Linux implementation of the hook from builtins.c to some
> Linux-specific file since you can't assume OPTION_GLIBC or OPTION_BIONIC
> are defined for other targets.
>
> --
> Joseph S. Myers
> joseph@codesourcery.com

Attachment: libc_has_function_3.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]