RE: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

["Joey Ye" <joey dot ye at arm dot com>]

> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Saturday, December 15, 2012 01:20
> To: Joey Ye
> Cc: gcc-patches@gcc.gnu.org; Joseph Prostko
> Subject: Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c
> Can't you do
> 
> +# Disable jcr section if we're not building java
> +case ,${enable_languages}, in
> +  *java*)
> +    use_jcr_section=1
> +    ;;
> +  *)
> +    use_jcr_section=0
> +    ;;
> +esac
> 
> in libgcc/configure.ac?
> 
> BTW, checking *,java,* is wrong for
> 
> --enable-languages=c,c++,java
Oh yes, it works. I didn't expect top level configure expands
--enable-languages=all to individual languages. Patch simplified.

However, I noticed that patterns like "*,java,*)" are widely used in
configure and they do work. Can you explain more why it is wrong?

      * libgcc/Makefile.in: Include TARGET_USE_JCR_SECTION in CFLAGS.
      * libgcc/configure.ac (use_jcr_section): New variable.
      * libgcc/configure: Regenerated.
      * libgcc/crtstuff.c: Check TARGET_USE_JCR_SECTION.

Attachment: jcr_diable_non_java-1217.patch
Description: Binary data