Re: PATCH: Remove AM_MAKEFLAGS from libsanitizer

[Paolo Bonzini <bonzini at gnu dot org>]

Il 12/12/2012 15:41, H.J. Lu ha scritto:
> MAKEOVERRIDES is used for multilib.  I got
> 
> /bin/sh ../libtool --tag=CXX   --mode=compile  -D_GNU_SOURCE -D_DEBUG
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
> -DASAN_HAS_EXCEPTIONS=1 -DASAN_FLEXIBLE_MAPPING_AND_OFFSET=0
> -DASAN_NEEDS_SEGV=1  -I.
> -I/export/gnu/import/git/gcc/libsanitizer/asan  -I
> /export/gnu/import/git/gcc/libsanitizer/include -I
> /export/gnu/import/git/gcc/libsanitizer  -Wall -W
> -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long -fPIC
> -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables
> -fvisibility=hidden -Wno-variadic-macros -Wno-c99-extensions
> -I../../libstdc++-v3/include
> -I../../libstdc++-v3/include/x86_64-unknown-linux-gnu
> -I/export/gnu/import/git/gcc/libsanitizer/../libstdc++-v3/libsupc++ -g
> -O2 -D_GNU_SOURCE  -m32 -MT asan_malloc_linux.lo -MD -MP -MF
> .deps/asan_malloc_linux.Tpo -c -o asan_malloc_linux.lo
> /export/gnu/import/git/gcc/libsanitizer/asan/asan_malloc_linux.cc
> libtool: compile: unrecognized option `-D_GNU_SOURCE'
> libtool: compile: Try `libtool --help' for more information.
> make[8]: *** [asan_allocator.lo] Error 1
> make[8]: *** Waiting for unfinished jobs....
> libtool: compile: unrecognized option `-D_GNU_SOURCE'
> libtool: compile: Try `libtool --help' for more information
> 
> I checked in this patch to restore MAKEOVERRIDES.

This will break "make CFLAGS=-g".  Please revert the AM_MAKEFLAGS change
fully.

However, your patch that removed AM_MAKEFLAGS similarly broke "make
CC=foo".  While it is much less useful, this nevertheless may be the
sign of a bigger problem.  Why did you need to remove CC/CXX from
AM_MAKEFLAGS in the first place?

Paolo