This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR c++/53609 - Wrong argument deduction for pack expansion in argument pack

On 12/11/2012 10:55 AM, Dodji Seketeli wrote: 
Oops, it seems I was too hasty in trying to do away with the
instantiation_yields_no_list_p parameter to
gen_elem_of_pack_expansion_instantiation.

I still think that the elem function should just deal with the single element case; the cases where we can't do a piecewise substitution should be handled outside the elem function.

I suppose we should keep this for has_empty_arg, but I'd like to do
away with special handling of the arg_from_parm_pack case if possible,
as it's a lot of extra complexity.

OK, done.

Looks like you only removed the check from that one if; I'd like to do away with the arg_from_parm_pack function entirely if we can.

Jason

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]