This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Bugfix: Additional parameter for canonicalize comparison
- From: Oleg Endo <oleg dot endo at t-online dot de>
- To: Richard Henderson <rth at redhat dot com>
- Cc: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, gcc-patches at gcc dot gnu dot org, richard dot earnshaw at arm dot com, kkojima at gcc dot gnu dot org, uweigand at de dot ibm dot com
- Date: Sat, 08 Dec 2012 01:16:16 +0100
- Subject: Re: [PATCH] Bugfix: Additional parameter for canonicalize comparison
- References: <20121206082527.GA13645@bart> <50C24576.1050508@redhat.com>
On Fri, 2012-12-07 at 13:37 -0600, Richard Henderson wrote:
> On 2012-12-06 02:25, Andreas Krebbel wrote:
> > ! targetm.canonicalize_comparison ((int*)&compare_code, &op0, &op1, 1);
>
> The basic approach seems sound. But this cast is distinctly uncool.
>
> And why the unused return value? If you didn't need it, why add it?
>
>
> r~
For the SH part, can't the 'sh_canonicalize_comparison_1' just be named
'sh_canonicalize_comparison' and have it overload the target hook
function?
Cheers,
Oleg