This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR rtl-optimization/55604]: fix ICE in remove_some_program_points_and_update_live_ranges
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Vladimir Makarov <vmakarov at redhat dot com>, Aldy Hernandez <aldyh at redhat dot com>, Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 5 Dec 2012 14:36:43 -0500
- Subject: Re: [PR rtl-optimization/55604]: fix ICE in remove_some_program_points_and_update_live_ranges
On 12-12-05 1:13 PM, Aldy Hernandez wrote:
>> This is a division by zero ICE.
>> In the testcase in the PR, both `n' and `lra_live_max_point' are zero. I have opted to inhibit the dump when lra_live_max_point is zero, but I can just as easily avoiding printing the percentage in this case.
> Interesting. I never thought that is possible.
>> Let me know what you prefer.
>> OK for trunk?
> Yes, it is ok if you add the testcase for GCC testsuite. It would be nice if you add analogous code for ira-lives.c::remove_some_program_points_and_update_live_ranges too.
I agree with Steven, this patch seems to be fixing the symptom, not
the problem. Please re-consider if Steven's patch is a better
solution.
Thanks, David