This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR55570
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 3 Dec 2012 13:50:08 +0100
- Subject: Re: [PATCH] Fix PR55570
- References: <20121203123628.GK10621@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Dec 03, 2012 at 01:36:28PM +0100, Marek Polacek wrote:
> We segfaulted on attached testcase, because we were accessing
> ->typed.type field via TREE_TYPE, but IDENTIFIER_NODEs don't contain
> ->typed element at all. Fixed by switching the expressions in
> a condition, so we always first check that we're operating on
> INTEGER_CST.
> Regtested/bootstrapped on x86_64-linux, ok for trunk and 4.7 branch?
>
> 2012-12-03 Marek Polacek <polacek@redhat.com>
>
> PR c/55570
> * c-common.c (check_user_alignment):
Missing descrption of the change above, I'd say
Swap order of tests, check TREE_CODE first.
or similar.
Ok with that change.
Jakub