This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add --with-build-config=bootstrap-asan support
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: Tobias Burnus <burnus at net-b dot de>, "H.J. Lu" <hjl dot tools at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 29 Nov 2012 20:06:02 +0100
- Subject: Re: [PATCH] Add --with-build-config=bootstrap-asan support
- References: <20121122203747.GA4264@gmail.com> <50B79D18.6050601@net-b.de> <50B7A866.4050804@oracle.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote:
> On 11/29/2012 06:36 PM, Tobias Burnus wrote:
> >H.J. Lu wrote:
> >>This patch adds --with-build-config=bootstrap-asan support. Tested on
> >>Linux/x86-64. OK to install?
> >
> >I think that patch has broken bootstrap for me. If I do a normal
> >bootstrap, Stage1 fails with:
> >
> >libtool: compile: unrecognized option `-D_GNU_SOURCE'
> >libtool: compile: Try `libtool --help' for more information.
> >make[4]: *** [interception_linux.lo] Error 1
> >make[4]: Leaving directory `/home/burnus/gcc/build/x86_64-unknown-linux-gnu/libsanitizer/interception'
> Likewise here. Would it be possible to revert the offending commit,
> in the meanwhile?
Yes, H.J., please revert the patch, I thought you have tested it alone
without any further patches. For the -I patch, I really would prefer if
libsanitizer just had a dependency on libstdc++ at toplevel
(configure-target-sanitizer depending on all-target-libstdc++-v3),
then you can (and similarly for host variants if we need host sanitizer at
all). Then you should be able to use scripts/testsuite_flags
--build-includes just fine.
Jakub