This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, PR52654, C++11] Warn on overflow in user-defined literals

From: Jason Merrill <jason at redhat dot com>
To: Ed Smith-Rowland <3dw4rd at verizon dot net>
Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Wed, 28 Nov 2012 19:31:24 -0500
Subject: Re: [PATCH, PR52654, C++11] Warn on overflow in user-defined literals
References: <50B69AA0.2000102@verizon.net>

On 11/28/2012 06:13 PM, Ed Smith-Rowland wrote:

Ultimately we should probably revisit this and 54413 by parsing the literal
numbers in the C++ front end.  That won't happen for 4.8.

That sounds like you're proposing to duplicate code?

-  /* Both C and C++ require a diagnostic for a floating constant
-     outside the range of representable values of its type.  Since we
-     have __builtin_inf* to produce an infinity, this is now a
-     mandatory pedwarn if the target does not support infinities.  */
+      /* Both C and C++ require a diagnostic for a floating constant
+	 outside the range of representable values of its type.  Since we
+	 have __builtin_inf* to produce an infinity, this is now a
+	 mandatory pedwarn if the target does not support infinities.  */

This seems unintentional.

OK with that indentation change removed.

Jason

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]