This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[asan] Another ICE fix
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Dodji Seketeli <dseketel at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 27 Nov 2012 19:46:30 +0100
- Subject: [asan] Another ICE fix
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
Hi!
E.g. on c_char_tests.f03 we have a stmt like
_2 = VIEW_CONVERT_EXPR<character(kind=1)[1:1]>(121)[1]{lb: 1 sz: 1};
after inlining (wonder why we never fold that to 121), which asan
incorrectly considered to be a load and thus attempted to instrument it,
by taking address of the rhs.
Fixed thusly, ok for trunk?
2012-11-27 Jakub Jelinek <jakub@redhat.com>
* asan.c (instrument_assignment): Instrument lhs only
for gimple_store_p and rhs1 only for gimple_assign_load_p.
--- gcc/asan.c.jj 2012-11-27 17:37:10.000000000 +0100
+++ gcc/asan.c 2012-11-27 18:37:21.316247456 +0100
@@ -1358,10 +1358,12 @@ instrument_assignment (gimple_stmt_itera
gcc_assert (gimple_assign_single_p (s));
- instrument_derefs (iter, gimple_assign_lhs (s),
- gimple_location (s), true);
- instrument_derefs (iter, gimple_assign_rhs1 (s),
- gimple_location (s), false);
+ if (gimple_store_p (s))
+ instrument_derefs (iter, gimple_assign_lhs (s),
+ gimple_location (s), true);
+ if (gimple_assign_load_p (s))
+ instrument_derefs (iter, gimple_assign_rhs1 (s),
+ gimple_location (s), false);
}
/* Instrument the function call pointed to by the iterator ITER, if it
Jakub