This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[RFA 6/8] validate_failures.py: remove pass/fail from GetBuildData
- From: Doug Evans <dje at google dot com>
- To: dnovillo at google dot com, gcc-patches at gcc dot gnu dot org
- Date: Sat, 24 Nov 2012 14:54:07 -0800
- Subject: [RFA 6/8] validate_failures.py: remove pass/fail from GetBuildData
Hi.
This sixth patch simplifies calls to GetBuildData.
It never returns false and always terminates the process with an error message
(which is fine by me).
Ok to check in?
2012-11-24 Doug Evans <dje@google.com>
* testsuite-management/validate_failures.py: Remove pass/fail indicator from
result of GetBuildData.
--- validate_failures.py.options 2012-11-24 13:40:57.616245431 -0800
+++ validate_failures.py 2012-11-24 13:44:05.118039626 -0800
@@ -284,7 +284,7 @@ def GetBuildData():
options.build_dir)
print 'Source directory: %s' % srcdir
print 'Build target: %s' % target
- return srcdir, target, True
+ return srcdir, target
def PrintSummary(msg, summary):
@@ -326,9 +326,7 @@ def PerformComparison(expected, actual,
def CheckExpectedResults():
if not options.manifest:
- (srcdir, target, valid_build) = GetBuildData()
- if not valid_build:
- return False
+ (srcdir, target) = GetBuildData()
manifest_path = _MANIFEST_PATH_PATTERN % (srcdir, target)
else:
manifest_path = options.manifest
@@ -348,10 +346,7 @@ def CheckExpectedResults():
def ProduceManifest():
- (srcdir, target, valid_build) = GetBuildData()
- if not valid_build:
- return False
-
+ (srcdir, target) = GetBuildData()
manifest_path = _MANIFEST_PATH_PATTERN % (srcdir, target)
if os.path.exists(manifest_path) and not options.force:
Error('Manifest file %s already exists.\nUse --force to overwrite.' %
@@ -369,9 +364,7 @@ def ProduceManifest():
def CompareBuilds():
- (srcdir, target, valid_build) = GetBuildData()
- if not valid_build:
- return False
+ (srcdir, target) = GetBuildData()
sum_files = GetSumFiles(options.results, options.build_dir)
actual = GetResults(sum_files)