This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix sanitizer build on sparc64.


Konstantin Serebryany <konstantin.s.serebryany@gmail.com> writes:

> On Wed, Nov 21, 2012 at 2:50 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> David Miller <davem@davemloft.net> writes:
>>
>>> +// Are we using 32-bit or 64-bit syscalls?
>>> +// x32 (which defines __x86_64__) has __WORDSIZE == 32
>>> +// but it still needs to use 64-bit syscalls.
>>> +#if defined(__x86_64__) || __WORDSIZE == 64
>>
>> I don't think it is a good idea to use a glibc-internal macro.  How
>> about __LP64__?
>
> __WORDSIZE is used throughout the library;

That doesn't make it any better.

> it is also redefined
> properly for the compilers which don't have it and may not have
> __LP64__

??? __WORDSIZE is only defined by glibc. __LP64__ (or _LP64) is a
standard macro defined by the compiler.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]