This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix up var-tracking notes emitted in between bbs (PR middle-end/43631)


On Thu, Nov 15, 2012 at 12:02 AM, Jakub Jelinek wrote:
> Hi!
>
> Steven has been complaining for some years that var-tracking inserts
> NOTE_INSN_VAR_LOCATION (and NOTE_INSN_CALL_ARG_LOCATION) notes sometimes
> in between basic blocks, but with BLOCK_FOR_INSN set (or sometimes extends
> a bb ending originally with a noreturn or throwing call by a note or more
> after it).  Fixed thusly, bootstrapped/regtested on x86_64-linux and
> i686-linux, ok for trunk?

Many thanks again for fixing this!
Do you think it's safe to add a verify_flow_info call at the end of
var-tracking to make sure there will be no regressions from here?

In case people are curious why this is IMHO so important: This was the
last major obstacle for some ports to keep the CFG around until
'final'.

Ciao!
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]