Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

[Dodji Seketeli <dodji at redhat dot com>]

Hans-Peter Nilsson <hans-peter.nilsson@axis.com> a Ãcrit:

> While the fallout(*) from the libsanitizer commit is handled,
> it's obvious it should have a noconfigdirs= section in
> toplevel/configure.ac like the other target libs.  Here's what I
> committed after observing that a cris-elf build passed, where it
> previously failed building libsanitizer which wrongly tries to
> compile using -fPIC despite checking in its configure.ac IIUC.

Thank you for doing this.

> But, I'd like to update the target contents there to something a
> bit more generic.
>
> Maybe disable libsanitizer everywhere except for (referring to
> the three common target-related file-name parts in libsanitizer)
> "mac", "win" and "linux"?  Or disable everywhere except x86_64 /
> i386?  That's the only port that defines the required
> TARGET_ASAN_SHADOW_OFFSET.

FWIW, I'd think we should just disable it everywhere except on x86_64 /
i*86 for now, as these are the only targets that define
TARGET_ASAN_SHADOW_OFFSET.

What do the maintainers think?

[...]

> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 193455)
> +++ configure.ac	(working copy)
> @@ -547,6 +547,13 @@ case "${target}" in
>      ;;
>  esac
>  
> +# Disable libsanitizer for some systems.
> +case "${target}" in
> +  cris-*-* | crisv32-*-* | mmix-*-*)
> +    noconfigdirs="$noconfigdirs target-libsanitizer"
> +    ;;
> +esac
> +

[...]

-- 
		Dodji