Re: [PATCH] Less restrictive regex in const-uniq-1.c

[Andrew Pinski <pinskia at gmail dot com>]

On Tue, Nov 6, 2012 at 6:54 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
> The regex in const-uniq-1.c assumes ELF label format, which does not
> match AIX XCOFF.  The following patch broadens the regex so that it
> also correctly matches on AIX.
>
>         * const-uniq-1.c: Expand regex to match AIX XCOFF labels.
>
> Index: const-uniq-1.c
> ===================================================================
> --- const-uniq-1.c      (revision 193203)
> +++ const-uniq-1.c      (working copy)
> @@ -20,5 +20,5 @@
>    return a[i+1];
>  }
>
> -/* { dg-final { scan-tree-dump-times "L\\\$?C0" 2 "gimple" } } */
> +/* { dg-final { scan-tree-dump-times "L\\\$?C\\\.*0" 2 "gimple" } } */

I think .* will match too much as it will match newlines too.  I think
[^\n\]* is better.

Thanks,
Andrew Pinski


>  /* { dg-final { cleanup-tree-dump "gimple" } } */