This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix debug info for expr and jump stmt


On Tue, Oct 30, 2012 at 8:29 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Tue, Oct 30, 2012 at 4:21 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>> On Tue, Oct 30, 2012 at 04:15:38PM +0100, Richard Biener wrote:
>>> So maybe TER (well, those looking up the stmt) should pick the location
>>> from the TERed statement properly then?
>>
>> Perhaps, but Micha's patch doesn't do that.
>> But in that case IMHO it still would help to set all expr locations to
>> UNKNOWN_LOCATION during gimple lowering, to make it clear we ignore
>> the locations.
>
> Yes indeed.

I agree, but this looks like too bold a move at this point. Shall we
do that in 4.8?

BTW, I updated the patch to ensure pr43479.c works fine. The testing
is still on-going.

Dehao

gcc/ChangeLog:
2012-10-25  Dehao Chen  <dehao@google.com>

        * tree-eh.c (do_return_redirection): Set location for jump statement.
        (do_goto_redirection): Likewise.
        (frob_into_branch_around): Likewise.
        (lower_try_finally_nofallthru): Likewise.
        (lower_try_finally_copy): Likewise.
        (lower_try_finally_switch): Likewise.
        * expr.c (store_expr): Use current insn location instead of expr
        location.
        (expand_expr_real): Likewise.
        (expand_expr_real_1): Likewise.

gcc/testsuite/ChangeLog:
2012-10-25  Dehao Chen  <dehao@google.com>

        * g++.dg/debug/dwarf2/block.C: New testcase.

Attachment: patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]