This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix debug info for expr and jump stmt
Hi,
On Mon, 29 Oct 2012, Richard Biener wrote:
> > Well, you merely moved the bogus code to gimple-low.c. It is bogus
> > because you unconditionally overwrite TREE_BLOCK of all operands (and all
> > operands operands) with the statements block. I assume the unit-test you
> > added shows the problem you were trying to fix?
> >
> > From the scan-assembler-no directive I'm not really sure what exactly the
> > problem is you're seeing. Can you try to describe it with words for the
> > example code? Which operands has no tree-block where it should have one,
> > or which one has the wrong tree-block?
>
> trees without block could be an issue when we extract them to some other
> statement (then without block), and move that to some random place.
Even then it would be either the frontends job to set the block, or the
the job of the pass that introduced the new expression, when there is a
clearly sane candidate for the block.
> But the only issue should be that the stmt/expressions effective block
> becomes a different one (the currently "active" one during expansion).
Yep.
> I don't see how we could end up generating too many block location
> DIEs because of this.
And even if, I don't see what's the _problem_ with too many block
locations, except bloat.
Ciao,
Michael.