This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH GCC]Fix test case failure reported in PR54989


On 10/22/2012 02:15 AM, Bin Cheng wrote:


-----Original Message-----
From: Jakub Jelinek [mailto:jakub@redhat.com]
Sent: Monday, October 22, 2012 3:16 PM
To: Bin Cheng
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH GCC]Fix test case failure reported in PR54989

On Mon, Oct 22, 2012 at 11:00:08AM +0800, Bin Cheng wrote:
The test case "gcc/testsuite/gcc.dg/hoist-register-pressure.c" is
failed on x86_64-apple-darwin because it uses more registers than
x86_64-linux. This can be fixed by simplifying the case using fewer
registers.

Tested on x86_64-apple-darwin/x86_64-linux, is it OK?

I'd say it is better to do the scan-rtl-dump only on nonpic targets, that
way
it won't be done on darwin or for testing with --target_board=unix/-fpic
where
it would fail too. You can add the test with smaller register pressure as
a
new test (hoist-register-pressure2.c).


Hi Jakub, Thanks for the suggestion. Updated patch as attached. Now it can work with -fPIC/-fno-PIC options. Tested on x86_64-apple-darwin/x86-linux, is it OK.

Thanks

gcc/testsuite/ChangeLog
2012-10-22  Bin Cheng  <bin.cheng@arm.com>

	* gcc.dg/hoist-register-pressure-1.c: Rename from
	hoist-register-pressure.c. Add nonpic condition.
	* gcc.dg/hoist-register-pressure-2.c: New test.
This is fine. Sorry for the delay.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]