This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gcc 4.7 libgo patch committed: Set libgo version number
On Tue, Oct 23, 2012 at 9:27 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Oct 23, 2012 at 06:16:25PM +0200, Matthias Klose wrote:
>> On 23.10.2012 06:55, Ian Lance Taylor wrote:
>> > PR 54918 points out that libgo is not using version numbers as it
>> > should. At present none of libgo in 4.6, 4.7 and mainline are
>> > compatible with each other. This patch to the 4.7 branch sets the
>> > version number for libgo there. Bootstrapped and ran Go testsuite on
>> > x86_64-unknown-linux-gnu. Committed to 4.7 branch.
>>
>> changing the soname of a runtime library on the branch? I don't like this idea
>> at all.
>
> Me neither. You should just make sure you increment the soname on the trunk
> whenever new major release has ABI changes, and don't do ABI changes on the release
> branches.
The problem is that I forgot to do that when the 4.7 branch was
created. So the 4.7 branch and the 4.6 branch were using the same
SONAME although they had completely different ABIs.
That is, there is no ABI change on the 4.7 branch. I'm setting the
SONAME to distinguish it from the 4.6 branch.
I agree is not ideal but it seems like the best approach under the
circumstances.
I'll roll it back if y'all continue to think it is a bad idea.
Ian