This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [asan] migrate runtime from llvm
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Wei Mi <wmi at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Diego Novillo <dnovillo at google dot com>, David Li <davidxl at google dot com>
- Date: Mon, 15 Oct 2012 23:28:43 -0700
- Subject: Re: [asan] migrate runtime from llvm
- References: <CA+4CFy4msme9qjmMoB2SKoOoMphUDv_M9Mtb1b+fca0qFPZEyw@mail.gmail.com>
On Mon, Oct 15, 2012 at 11:25 PM, Wei Mi <wmi@google.com> wrote:
> Hi,
>
> I create a patch to migrate llvm runtime to asan branch. The
> configure.ac is a preliminary version and almost doesn't contain any
> portability check. I build it and test my own small case only and it
> works. Just send it out to ask for a preliminary review. The patch is
> zipped to keep it smaller than 400K (required by sourceware.org).
> Because I am a fresh man to gcc, please forgive me to send out a patch
> with many errors.
This is a good start. Can you send a patch out without including
libasan so at least the toplevel parts can be reviewed easier?
Also the changelog entry for gcc.c go under the gcc/ChangeLog rather
than the toplevel one.
Thanks,
Andrew Pinski
>
> Thanks,
> Wei.
>
> gcc/ChangeLog:
> 2012-10-15 Wei Mi <wmi@google.com>
>
> migrate llvm runtime to asan branch
> * configure.ac: Add libasan to target_libraries
> * Makefile.def: Ditto
> * configure: Regenerate
> * Makefile.in: Regenerate
> * gcc/gcc.c: Add -lasan -lpthread ... to link command if -fasan is on
> * libasan: New directory for asan runtime