Re: [Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p

[Hans-Peter Nilsson <hp at bitrange dot com>]

On Thu, 20 Sep 2012, Georg-Johann Lay wrote:
> mode_dependent_address_p is not sensitive to the address space of the passed
> address.  Thus, add an addr_space_t parameter to the hook.

Borderline obvious. :)  (J/k; the added functionality seems
obvious but the implementation may have non-obvious issues,
though I saw none.)

> One more question:
> This patch changes a target hook.  Is there a place in the internals
> that gathers changes by naming *all* the changed/extended/removed/poisoned
> interfaces?   So that developers can read the list of functions/macros/hooks
> to learn if something interesting happened as they update the GCC sources?

Someone once suggested an internal-changes web-page or file for
the benefit of out-of-tree ports and patches, but I don't know
what happened to that.  I'd look in the wiki.

> Diff'ing the internals texi is tedious and too much noise as it would be
> helpful to get a briefing.
>
>
> Johann
>
> 	PR 54635

Better spell that "PR other/54635" in the ChangeLog; if you
don't get the syntax right it won't automatically show up in
bugzilla.

> 	* doc/tm.texi.in (TARGET_MODE_DEPENDENT_ADDRESS_P): Document new
> 	parameter addrspace.
...


brgds, H-P