This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite] vect effective targets should use arm_neon_ok


On 09/18/2012 12:54 PM, Janis Johnson wrote:
> In most cases a test that requires ARM NEON should use effective target
> arm_neon, which means that flags run for all tests include NEON support.
> The result is cached the first time it is checked for a multilib.
> 
> Vectorization tests, when run for ARM, add flags to support NEON if it's
> OK to do so, but those flags are not reflected in the cached results for
> arm_neon, nor should they be.  Because of this, vect effective-target
> checks should use arm_neon_ok (as most already do) instead of arm_neon.
> 
> This patch changes the checks for 7 effective targets, allowing more
> tests to run and decreasing the number of failures.  The only new
> failures I've seen in tests on arm-none-eabi with a variety of test
> multilibs are for big-endian with vect_multiple_sizes, which means
> that vect_multiple_sizes should be false for big endian or that there's
> a bug in ARM big-endian support.

Oops, I got that wrong.  There are other effective-targets that might
need arm_little_endian, but not vect_multiple_sizes.  I'll file a PR
when I have better information.

> Checked in on trunk as obvious.  I'll backport to 4.6 when it's open.
> 
> Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]