This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Set correct source location for deallocator calls
- From: Andrew Pinski <pinskia at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Dehao Chen <dehao at google dot com>, Mark Wielaard <mark at klomp dot org>, Bryce McKinlay <bmckinlay at gmail dot com>, Andrew Haley <aph at redhat dot com>, Richard Henderson <rth at redhat dot com>, Jason Merrill <jason at redhat dot com>, Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org, David Li <davidxl at google dot com>, java at gcc dot gnu dot org
- Date: Fri, 14 Sep 2012 21:27:34 -0700
- Subject: Re: [PATCH] Set correct source location for deallocator calls
- References: <CAO2gOZXfnETUe4wqjT7p6fd61hXreu9PDfqKxNz+HxpE0E7K0g@mail.gmail.com> <50243480.7090803@redhat.com> <CAO2gOZURCuWUk2MVwCwmwrijNzWxJt3q=HUpU7=Qv6zB9e-uqA@mail.gmail.com> <50254A50.8070208@redhat.com> <CAO2gOZXhHuFGJ0z=jvkYKZ84EoDaPSYVjxS7QzGore56SyhWyQ@mail.gmail.com> <50255B35.9020705@redhat.com> <CAO2gOZWe+qMrVyvOoo7Ek-di0NKZxxU4Z=pqrDCqqCCAfctZOw@mail.gmail.com> <50258712.4070002@redhat.com> <CAO2gOZUQQjmKtooyXXAfgFoNVbeNwtT+P=E7pQ6jC=e07Nsr2g@mail.gmail.com> <CAO2gOZX-Gn+b6LEzps5zxhgmwQWcJ-zFqG=a7hesW6fbVyxZYQ@mail.gmail.com> <502E6774.8050609@redhat.com> <CAO2gOZWhueDAShNLbNcJpkHA6QqXk1LNZhEMFvfT77aTZTCH9w@mail.gmail.com> <503F7876.7030606@redhat.com> <503F84A9.8010504@redhat.com> <503F95D8.5010506@redhat.com> <CAO2gOZUxD9-Y3O6iS22HNEHUWaH=0Cm97FZ+KHmhkLmCzahVAA@mail.gmail.com> <CALUNu-qXtr3pSTa8j60nD4Y4QK6VNAEOaPh34RRd4qt671gzkA@mail.gmail.com> <CALUNu-p2-rvGCLYn9s1gy-rGOq+cOwZCw9S1Twbjcba0dVKTfQ@mail.gmail.com> <50463661.1020303@redhat.com> <CALUNu-oP9dqG63EHyN18gYj4P3gwrrJcp4Zgrz-pABNxabmsCg@mail.gmail.com> <1346839095.9368.1.camel@springer.wildebeest.org> <CAO2gOZVhW2+VfKU8+n2qrcKr9fgM1G4bRyUTUB_0DATH9eEW6w@mail.gmail.com> <CAMe9rOqpzNa-u7b-nUfeBkpSed5Fkh16tzw4_uyptpMpKfhUfA@mail.gmail.com>
On Fri, Sep 14, 2012 at 9:25 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sat, Sep 8, 2012 at 2:42 PM, Dehao Chen <dehao@google.com> wrote:
>> Hi,
>>
>> I've added a libjava unittest which verifies that this patch will not
>> break Java debug info. I've also incorporated Richard's review in the
>> previous mail. Attached is the new patch, which passed bootstrap and
>> all gcc/libjava testsuites on x86.
>>
>> Is it ok for trunk?
>>
>> Thanks,
>> Dehao
>>
>> gcc/ChangeLog:
>> 2012-09-08 Dehao Chen <dehao@google.com>
>>
>> * tree-eh.c (goto_queue_node): New field.
>> (record_in_goto_queue): New parameter.
>> (record_in_goto_queue_label): New parameter.
>> (lower_try_finally_dup_block): New parameter.
>> (maybe_record_in_goto_queue): Update source location.
>> (lower_try_finally_copy): Likewise.
>> (honor_protect_cleanup_actions): Likewise.
>> * gimplify.c (gimplify_expr): Reset the location to unknown.
>>
>> gcc/testsuite/ChangeLog:
>> 2012-09-08 Dehao Chen <dehao@google.com>
>>
>> * g++.dg/debug/dwarf2/deallocator.C: New test.
>>
>> libjava/ChangeLog:
>> 2012-09-08 Dehao Chen <dehao@google.com>
>>
>> * testsuite/libjava.lang/sourcelocation.java: New cases.
>> * testsuite/libjava.lang/sourcelocation.out: New cases.
>
> On Linux/x86, I got
>
> FAIL: sourcelocation -O3 -findirect-dispatch output - source compiled test
> FAIL: sourcelocation -O3 output - source compiled test
> FAIL: sourcelocation -findirect-dispatch output - source compiled test
> FAIL: sourcelocation output - source compiled test
>
> spawn [open ...]^M
> -1
> -1
> -1
> PASS: sourcelocation -findirect-dispatch execution - source compiled test
> FAIL: sourcelocation -findirect-dispatch output - source compiled test
I bet you have an older addr2line installed.
Thanks,
Andrew Pinski