This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] Remove uses of ATTRIBUTE_UNUSED in the function parameters

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
Date: Tue, 11 Sep 2012 18:17:18 +0200
Subject: Re: [C++ Patch] Remove uses of ATTRIBUTE_UNUSED in the function parameters
References: <504F58C8.5050502@oracle.com> <20120911153732.GU22619@tucnak.redhat.com>

On 09/11/2012 05:37 PM, Jakub Jelinek wrote:

On Tue, Sep 11, 2012 at 05:29:12PM +0200, Paolo Carlini wrote:

PS: slightly interesting, in a couple of cases -
write_unnamed_type_name, wrap_cleanups_r - the parameters were
actually used.

Just a general comment, often an argument is only conditionally used,
e.g. depending on some preprocessor macro (e.g. target hook).  In that
case unnamed parameter is not an option, but dropping ATTRIBUTE_UNUSED is
not desirable either.

Of course. As far as I can see, that isn't the case for the C++ front-end uses, but hey, if you spot something which *may* be less than straightforward in my patch, please let me know asap!

Paolo.

References:
- [C++ Patch] Remove uses of ATTRIBUTE_UNUSED in the function parameters
  - From: Paolo Carlini
- Re: [C++ Patch] Remove uses of ATTRIBUTE_UNUSED in the function parameters
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]